Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-started: full refactoring #1074

Closed
wants to merge 56 commits into from
Closed

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Mar 19, 2020

Should change PR target to master branch when #1051 is merged.


Other questions:

@shcheklein shcheklein temporarily deployed to dvc-landing-refactor-ge-pgzpne March 19, 2020 07:47 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-pgzpne March 19, 2020 15:04 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-pgzpne March 19, 2020 15:11 Inactive
@jorgeorpinel jorgeorpinel changed the title [WIP] get-started: full refactoring get-started: full refactoring Mar 20, 2020
@jorgeorpinel jorgeorpinel changed the base branch from refactor/get-started to master March 20, 2020 23:15
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-pgzpne March 21, 2020 03:56 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-pgzpne March 21, 2020 04:40 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-pgzpne March 23, 2020 09:31 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-pgzpne March 23, 2020 10:19 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-pgzpne March 24, 2020 18:23 Inactive
@jorgeorpinel

This comment has been minimized.

@shcheklein shcheklein temporarily deployed to dvc-landing-refactor-ge-qj2qhn March 30, 2020 03:50 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-etwyy1 April 26, 2020 05:00 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-etwyy1 April 26, 2020 06:11 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-etwyy1 April 29, 2020 02:59 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request May 6, 2020
20 tasks
@jorgeorpinel

This comment has been minimized.

@casperdcl
Copy link
Contributor

casperdcl commented May 15, 2020

per #1074 (review) above

@jorgeorpinel / @shcheklein is there any way to automatically get these preview URLs in the CI? That way we could set them as the CHECK_LINKS_RELATIVE_URL (rather than https://dvc.org).

@jorgeorpinel
Copy link
Contributor Author

Idk, maybe the Heroku integration exposes some env vars but probably not worth the effort. I can ignore it, it's just always confusing at first, and you need to check the test results every time after this to make sure nothing else is failing.

@shcheklein
Copy link
Member

@casperdcl I think so, the problem is that we'll have to make CI script wait before we run it (for Heroku preview to be deployed)? may be we can make a separate GH action or something?

First of all we can set predictable URLs - https://devcenter.heroku.com/articles/github-integration-review-apps#selecting-the-url-pattern . Then just pull the main page with some (10 min?) timeout.

@casperdcl
Copy link
Contributor

sounds good; updated #1000

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-l1iiiw May 27, 2020 05:43 Inactive
update local remote note in all places
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-refactor-ge-l1iiiw May 27, 2020 21:56 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-refactor-ge-24khjm May 27, 2020 22:06 Inactive
@jorgeorpinel
Copy link
Contributor Author

closing in favor of #1367

@jorgeorpinel jorgeorpinel deleted the refactor/get-started-2 branch June 6, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants