-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get-started: full refactoring #1074
Conversation
…tarted index (WIP)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jorgeorpinel / @shcheklein is there any way to automatically get these preview URLs in the CI? That way we could set them as the |
Idk, maybe the Heroku integration exposes some env vars but probably not worth the effort. I can ignore it, it's just always confusing at first, and you need to check the test results every time after this to make sure nothing else is failing. |
@casperdcl I think so, the problem is that we'll have to make CI script wait before we run it (for Heroku preview to be deployed)? may be we can make a separate GH action or something? First of all we can set predictable URLs - https://devcenter.heroku.com/articles/github-integration-review-apps#selecting-the-url-pattern . Then just pull the main page with some (10 min?) timeout. |
sounds good; updated #1000 |
update local remote note in all places
closing in favor of #1367 |
Should change PR target to master branch when #1051 is merged.
Other questions:
See https://github.com/iterative/example-repos-dev (which produces https://github.com/iterative/example-repos)